Bug#869692: RFS: cyclograph/1.9.0-1

[Federico Brega]

Package: sponsorship-requests
Severity: important

Dear mentors,

I am looking for a sponsor for my package "cyclograph":

git://git.debian.org/pkg-running/cyclograph.git

It can be built with gbp.

Changes since the last upload:
This is important because it is currently affected by and RC bug, which
is closed by this upload.

cyclograph (1.9.0-1) UNRELEASED; urgency=medium

[ Federico Brega ]
* New upstream release
* Added cyclograph-qt5 ui
* Debhelper compat version updated to 9
* Updated Standards to 4.0.0
* Updated gtk to webkit2 version 4.0 (closes: bug#866635)
* Added vcs field to debian/control

-- Federico Brega <***@gmail.com> Sat, 15 Jul 2017 16:16:41 +0200

Regards,
Federico Brega

[Andrey Rahmatullin]

And there are other changes (about python for example) that are not listed
in the changelog.

I listed all the changes done to files in the "debian" folder. The
other changes are
all made by upstream and, in my understanding, are out of scope from the debian
changelog.

* The package now depends on python3
Which package?
* The package now uses dh-python in combination with python3-setuptools
"in combination"?
* Added cyclograph-qt5 ui
Not clear that cyclograph-qt5 is a new subpackage.
* Debhelper compat version updated to 10
It's "compat level", see debhelper(7).
* Updated Standards to 4.0.0
It's "Standards-Version", and it's customary to add "(no change needed)"
if an upgrade to the new version didn't require anything (I assume you've
read the upgrade checklist?).
* Updated gtk to webkit2 version 4.0
Not clear what is "gtk" here.
* Added vcs field to debian/control
It's not a "vcs" field but Vcs-Git and Vcs-Browser.

You also didn't mention the switch to pybuild.

[Federico Brega]

On the git server you can find a new commit with all the changes requested.

Post by Andrey Rahmatullin
* The package now depends on python3
Which package?

It's both a build dependency and a runtime dependency of "cyclograph"
the main binary package. The cyclograph-qt5 and cyclograph-gtk3 binary
packages depend on cyclograph, so they all depend on python3.
Please take a look at the new changelog and see if this is now clear.

Post by Andrey Rahmatullin
* The package now uses dh-python in combination with python3-setuptools
"in combination"?

My understanding is that pybuild, provided by the dh-python package,
needs the setuptools for python3, but, since it cannot know if python2
or python3 is used, the correct B-D has to be manually added.
Please take a look at the new changelog and see if this is now clear.

Post by Andrey Rahmatullin
* Added cyclograph-qt5 ui
Not clear that cyclograph-qt5 is a new subpackage.

Ok, last entry in the changelog was about the removal of
cyclograph-qt4, but I can understand that a longer description in the
changelog is more useful.

Post by Andrey Rahmatullin
* Debhelper compat version updated to 10
It's "compat level", see debhelper(7).

Sorry for that. I confused the Debhelper version, with the compatibility level.

Post by Andrey Rahmatullin
* Updated Standards to 4.0.0
It's "Standards-Version", and it's customary to add "(no change needed)"
if an upgrade to the new version didn't require anything (I assume you've
read the upgrade checklist?).

I read the checklist[1] and I didn't find anything to be done.
"(no change needed)" added.

Post by Andrey Rahmatullin
* Updated gtk to webkit2 version 4.0
Not clear what is "gtk" here.

This is the "cyclograph-gtk3".

Post by Andrey Rahmatullin
* Added vcs field to debian/control
It's not a "vcs" field but Vcs-Git and Vcs-Browser.

Modified

Post by Andrey Rahmatullin
You also didn't mention the switch to pybuild.

Added

[1] https://www.debian.org/doc/packaging-manuals/upgrading-checklist.txt
--
Federico