Bug#861530: c-icap: Misleading error message if c-icap is running out of temp. diskspace

[Roland Schnabel]

Package: c-icap
Version: 1:0.3.4-2
Severity: minor
Tags: upstream

Dear Maintainer,

* What led up to the situation?
Configure c-icap with module libc-icap-mod-virus-scan

* What exactly did you do (or not do) that was effective (or ineffective)?
Configuration:
MaxServers 10
ThreadsPerChild 10
ServiceAlias avscan virus_scan?allow204=on&sizelimit=off&mode=simple
virus_scan.MaxObjectSize 5M
TmpDir /tmp
Free diskspace in /tmp: 700 MB
Downloading a file via squid3 that is larger than 700 MB

* What was the outcome of this action?
Log entry in c-icap logfile:
"Bug in the service. Please report to the service author!!!!"

* What outcome did you expect instead?
Log entry in c-icap logfile:
"Running out of temporary diskspace" or "Skipping c-icap module because file is too large for temp. diskspace"
Max. required temp. diskspace of above c-icap configuration is 500 MB. Free diskspace is 700 MB. So temp.
diskspace would be enough. But because of the ServiceAlias option for virus_scan "sizelimit=off" the c-icap
configuration for max. temp. diskspace is ignored. c-icap tries to download the file runs out of temp.
diskspaceand logs this very misleading error message. This makes it very hard to detect this error if you
have e.g. a large number of squid users that report infrequent error messages in their browser "internal
server error" and they are concurrently only downloading small files over squid.

-- System Information:
Debian Release: 8.7
APT prefers stable-updates
APT policy: (500, 'stable-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages c-icap depends on:
ii adduser 3.113+nmu3
ii libc6 2.19-18+deb8u7
ii libdb5.3 5.3.28-9
ii libicapapi3 1:0.3.4-2
ii lsb-base 4.1+Debian13+nmu1

c-icap recommends no packages.

Versions of packages c-icap suggests:
ii libc-icap-mod-virus-scan [libc-icap-module] 1:0.3.2-2+b1
ih squid3 3.4.8-6+deb8u4

-- Configuration Files:
/etc/c-icap/c-icap.conf changed:
PidFile /var/run/c-icap/c-icap.pid
CommandsSocket /var/run/c-icap/c-icap.ctl
Timeout 300
MaxKeepAliveRequests 100
KeepAliveTimeout 600
StartServers 3
MaxServers 10
MinSpareThreads 10
MaxSpareThreads 20
ThreadsPerChild 10
MaxRequestsPerChild 0
Port 1344
User c-icap
Group c-icap
ServerAdmin ***@rolandschnabel.de
ServerName gray1b
TmpDir /tmp
MaxMemObject 512000
DebugLevel 2
ModulesDir /usr/lib/x86_64-linux-gnu/c_icap
ServicesDir /usr/lib/x86_64-linux-gnu/c_icap
TemplateDir /usr/share/c_icap/templates/
TemplateDefaultLanguage en
LoadMagicFile /etc/c-icap/c-icap.magic
RemoteProxyUsers off
RemoteProxyUserHeader X-Authenticated-User
RemoteProxyUserHeaderEncoded on
acl localhost src 127.0.0.1/255.255.255.255 192.168.0.215/32
acl all src 0.0.0.0/0.0.0.0
acl ALLREQUESTS type REQMOD RESPMOD OPTIONS
icap_access allow ALLREQUESTS localhost
icap_access deny all
LogFormat myFormat "%tl - Local-IP:%15la Remote-IP:%15a HTTP-Server:%<A Status-Code:%-3is Recv-Size:%9I %im URL:%iu %huo"
ServerLog /var/log/c-icap/server.log
AccessLog /var/log/c-icap/access.log myFormat
Service echo srv_echo.so
Include virus_scan.conf

/etc/default/c-icap changed:
START=yes
DAEMON_ARGS=""


-- no debconf information

[Mathieu Parent]

Post by Roland Schnabel
Package: c-icap
Version: 1:0.3.4-2
Severity: minor
Tags: upstream
Dear Maintainer,

Hello,

Post by Roland Schnabel
* What led up to the situation?
Configure c-icap with module libc-icap-mod-virus-scan
* What exactly did you do (or not do) that was effective (or ineffective)?
MaxServers 10
ThreadsPerChild 10
ServiceAlias avscan virus_scan?allow204=on&sizelimit=off&mode=simple
virus_scan.MaxObjectSize 5M
TmpDir /tmp
Free diskspace in /tmp: 700 MB
Downloading a file via squid3 that is larger than 700 MB

OK. thanks for your report.Can you send this upstream? I won't have
time to deal with it soon.

Post by Roland Schnabel
* What was the outcome of this action?
"Bug in the service. Please report to the service author!!!!"
* What outcome did you expect instead?
"Running out of temporary diskspace" or "Skipping c-icap module because file is too large for temp. diskspace"
Max. required temp. diskspace of above c-icap configuration is 500 MB. Free diskspace is 700 MB. So temp.
diskspace would be enough. But because of the ServiceAlias option for virus_scan "sizelimit=off" the c-icap
configuration for max. temp. diskspace is ignored. c-icap tries to download the file runs out of temp.
diskspaceand logs this very misleading error message. This makes it very hard to detect this error if you
have e.g. a large number of squid users that report infrequent error messages in their browser "internal
server error" and they are concurrently only downloading small files over squid.

Regards