Discussion:
Bug#750837: ITP: moarvm -- virtual machine for Rakudo Perl 6 and NQP
(too old to reply)
gregor herrmann
2015-03-12 15:57:39 UTC
Permalink
You can find the first draft of packaging on my git repository[1].
That's a really god start.
Any news on moarvm packaging?
As I understand it's the preferred VM for Rakudo now, or something
similar :) and will be needed for the announced Perl6 released later
this year.

Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Kurt Ostbahn & Die Kombo: Na, so wirst ned oid
Dominique Dumont
2015-03-14 13:23:09 UTC
Permalink
Post by gregor herrmann
Any news on moarvm packaging?
Hmm no. The original plan was to Daniel to do the packaging work and me to
sponsor. I hope this plan still stands.
Post by gregor herrmann
As I understand it's the preferred VM for Rakudo now, or something
similar and will be needed for the announced Perl6 released later
this year.
Agreed. We will have to decide which backend do we want to provide: only
moarvm or more ?

Given the lack of manpower, I think that providing only more than one backend
is not realistic.

All the best
gregor herrmann
2015-03-14 18:28:59 UTC
Permalink
Post by Dominique Dumont
Post by gregor herrmann
Any news on moarvm packaging?
Hmm no. The original plan was to Daniel to do the packaging work and me to
sponsor. I hope this plan still stands.
Ok.
Post by Dominique Dumont
Post by gregor herrmann
As I understand it's the preferred VM for Rakudo now, or something
similar and will be needed for the announced Perl6 released later
this year.
Agreed. We will have to decide which backend do we want to provide: only
moarvm or more ?
Given the lack of manpower, I think that providing only more than one backend
is not realistic.
I know far too little about the whole Perl6 ecosystem to be able to
help here; my impression is just that we will need moarvm; and I
understand the point that maintaining other VMs might be too much
work to be worthwhile.


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Kings of Convenience: Rule My World
Daniel Dehennin
2015-03-14 21:36:18 UTC
Permalink
Post by Dominique Dumont
Post by gregor herrmann
Any news on moarvm packaging?
Hmm no. The original plan was to Daniel to do the packaging work and me to
sponsor. I hope this plan still stands.
Sorry for my long inactivity.

I just rework my packaging[1] against the latest MoarVM 2015.02 :

- install libmoar outside of the "standard linker path"[2]

- generate the manpage from the pod file

- use dpkg-buildflags instead of hardening-wrapper

Actually, lintian says:

W: moarvm source: empty-short-license-in-dep5-copyright (paragraph at line 50)
P: moarvm source: debian-watch-may-check-gpg-signature
W: moarvm: hardening-no-relro usr/bin/moar
I: moarvm: hardening-no-fortify-functions usr/bin/moar
W: moarvm: hardening-no-relro usr/lib/moar/libmoar.so
I: moarvm: hardening-no-fortify-functions usr/lib/moar/libmoar.so
I: moarvm: extended-description-is-probably-too-short

I think I'll need to patch the build system to use the environment
variables for *FLAGS for hardening.

I wonder if I should have a -dfsg branch to remove the 3rdparty
libatomic_ops and libtommath since I build against the Debian ones.

Regards.

Footnotes:
[1] http://git.baby-gnu.net/gitweb/gitweb.cgi?p=pkg-moarvm.git;a=summary

[2] https://github.com/MoarVM/MoarVM/issues/74
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
gregor herrmann
2015-03-15 02:21:32 UTC
Permalink
Post by Daniel Dehennin
Post by Dominique Dumont
Post by gregor herrmann
Any news on moarvm packaging?
Hmm no. The original plan was to Daniel to do the packaging work and me to
sponsor. I hope this plan still stands.
Sorry for my long inactivity.
No worries, thanks for your reply!
% git clone git://git.baby-gnu.net/pkg-moarvm.git
Cloning into 'pkg-moarvm'...
fatal: remote error: access denied or repository not exported: /pkg-moarvm.git
Post by Daniel Dehennin
- use dpkg-buildflags instead of hardening-wrapper
This should happen automagically with debhelper compat level 9 (which
you are already using).
Post by Daniel Dehennin
W: moarvm source: empty-short-license-in-dep5-copyright (paragraph at line 50)
Should be easy to fix by providing a short license name.
(Can be "other" if there is nothing ready-to-use.)
Post by Daniel Dehennin
P: moarvm source: debian-watch-may-check-gpg-signature
Can be ignored.
Post by Daniel Dehennin
W: moarvm: hardening-no-relro usr/bin/moar
I: moarvm: hardening-no-fortify-functions usr/bin/moar
W: moarvm: hardening-no-relro usr/lib/moar/libmoar.so
I: moarvm: hardening-no-fortify-functions usr/lib/moar/libmoar.so
I: moarvm: extended-description-is-probably-too-short
That's unfortunate and needs investigation.
Post by Daniel Dehennin
I think I'll need to patch the build system to use the environment
variables for *FLAGS for hardening.
Yup, looks like the *FLAGS are ignored.
Post by Daniel Dehennin
I wonder if I should have a -dfsg branch to remove the 3rdparty
libatomic_ops and libtommath since I build against the Debian ones.
If they are dfsg-free they can stay in the source package, as long as
they are not used. No need for the additional hassle of repackaging.


Maybe you could push the git repo to alioth (to the rakudo team
maybe?), then it's easier for others to clone/look/help out. What dou
you think? - No idea how pkg-rakudo works but I assume they are
welcoming since I know the some guys there :) And you're already a
project member.


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Bettina Wegner: Hab doch gewusst
Daniel Dehennin
2015-03-15 10:46:13 UTC
Permalink
Post by gregor herrmann
% git clone git://git.baby-gnu.net/pkg-moarvm.git
Cloning into 'pkg-moarvm'...
/pkg-moarvm.git
Sorry, I forgot the git-daemon-export-ok, it's ok now.
Post by gregor herrmann
Post by Daniel Dehennin
W: moarvm source: empty-short-license-in-dep5-copyright (paragraph at line 50)
Should be easy to fix by providing a short license name.
(Can be "other" if there is nothing ready-to-use.)
Great, I was wondering what to use in that case.
Post by gregor herrmann
Post by Daniel Dehennin
P: moarvm source: debian-watch-may-check-gpg-signature
Can be ignored.
Sure, it's just pedantic
Post by gregor herrmann
Post by Daniel Dehennin
W: moarvm: hardening-no-relro usr/bin/moar
I: moarvm: hardening-no-fortify-functions usr/bin/moar
W: moarvm: hardening-no-relro usr/lib/moar/libmoar.so
I: moarvm: hardening-no-fortify-functions usr/lib/moar/libmoar.so
I: moarvm: extended-description-is-probably-too-short
That's unfortunate and needs investigation.
Post by Daniel Dehennin
I think I'll need to patch the build system to use the environment
variables for *FLAGS for hardening.
Yup, looks like the *FLAGS are ignored.
Post by Daniel Dehennin
I wonder if I should have a -dfsg branch to remove the 3rdparty
libatomic_ops and libtommath since I build against the Debian ones.
If they are dfsg-free they can stay in the source package, as long as
they are not used. No need for the additional hassle of repackaging.
Ok, I was not sure about source files duplication.
Post by gregor herrmann
Maybe you could push the git repo to alioth (to the rakudo team
maybe?), then it's easier for others to clone/look/help out. What dou
you think? - No idea how pkg-rakudo works but I assume they are
welcoming since I know the some guys there :) And you're already a
project member.
Yes, that's why I rename my repository to pkg-moarvm like pkg-rakudo.

Regards.
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
gregor herrmann
2015-03-15 14:16:24 UTC
Permalink
Post by Daniel Dehennin
Post by gregor herrmann
% git clone git://git.baby-gnu.net/pkg-moarvm.git
Cloning into 'pkg-moarvm'...
fatal: remote error: access denied or repository not exported: /pkg-moarvm.git
Sorry, I forgot the git-daemon-export-ok, it's ok now.
Works, thanks!
Post by Daniel Dehennin
Post by gregor herrmann
Post by Daniel Dehennin
P: moarvm source: debian-watch-may-check-gpg-signature
Can be ignored.
Sure, it's just pedantic
And nothing we can fix.
Post by Daniel Dehennin
Post by gregor herrmann
Post by Daniel Dehennin
W: moarvm: hardening-no-relro usr/bin/moar
I: moarvm: hardening-no-fortify-functions usr/bin/moar
W: moarvm: hardening-no-relro usr/lib/moar/libmoar.so
I: moarvm: hardening-no-fortify-functions usr/lib/moar/libmoar.so
I: moarvm: extended-description-is-probably-too-short
That's unfortunate and needs investigation.
Post by Daniel Dehennin
I think I'll need to patch the build system to use the environment
variables for *FLAGS for hardening.
Yup, looks like the *FLAGS are ignored.
I looked into this now, see the attached patch series.
(Not perfect but a starting point.)
Post by Daniel Dehennin
Post by gregor herrmann
Maybe you could push the git repo to alioth (to the rakudo team
maybe?), then it's easier for others to clone/look/help out. What dou
you think? - No idea how pkg-rakudo works but I assume they are
welcoming since I know the some guys there :) And you're already a
project member.
Yes, that's why I rename my repository to pkg-moarvm like pkg-rakudo.
Excellent!


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Ry Cooder: The Very Thing That Makes You Rich (Makes Me Poor)
Daniel Dehennin
2015-03-15 14:33:00 UTC
Permalink
gregor herrmann <***@debian.org> writes:


[...]
Post by gregor herrmann
Post by Daniel Dehennin
Post by gregor herrmann
Yup, looks like the *FLAGS are ignored.
I looked into this now, see the attached patch series.
(Not perfect but a starting point.)
Thanks, I'll look at them just after my brewing meeting ;-)
Post by gregor herrmann
Post by Daniel Dehennin
Post by gregor herrmann
Maybe you could push the git repo to alioth (to the rakudo team
maybe?), then it's easier for others to clone/look/help out. What dou
you think? - No idea how pkg-rakudo works but I assume they are
welcoming since I know the some guys there :) And you're already a
project member.
Yes, that's why I rename my repository to pkg-moarvm like pkg-rakudo.
Excellent!
But it seems I can't create a new repository on alioth, I'll wait for an
admin to create the empty “pkg-moarvm.git” bare repository and then I'll
push here.

Regards.

NB: I'm not sure about keeping all the Cc: on all mails.
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Daniel Dehennin
2015-03-16 22:51:58 UTC
Permalink
gregor herrmann <***@debian.org> writes:


[...]
Post by gregor herrmann
Post by gregor herrmann
Yup, looks like the *FLAGS are ignored.
I looked into this now, see the attached patch series.
(Not perfect but a starting point.)
5 days ago it was half fixed upstream[1], today it's fully fixed[2].

I tested them and I need to disable PIE or I have this issue:

#+begin_src
gcc -o libmoar.so -O2 -DNDEBUG -g3 -Wl,-rpath,/usr/lib/moar -fPIE -pie -Wl,-z,relro -Wl,-z,now -shared -fPIC src/core/callsite.o src/core/args.o src/core/exceptions.o src/core/interp.o src/core/threadcontext.o src/core/compunit.o src/core/bytecode.o src/core/frame.o src/core/validation.o src/core/bytecodedump.o src/core/threads.o src/core/ops.o src/core/hll.o src/core/loadbytecode.o src/math/num.o src/core/coerce.o src/core/dll.o src/core/ext.o src/core/nativecall.o src/core/continuation.o src/core/intcache.o src/core/fixedsizealloc.o src/gen/config.o src/gc/orchestrate.o src/gc/allocation.o src/gc/worklist.o src/gc/roots.o src/gc/collect.o src/gc/gen2.o src/gc/wb.o src/gc/objectid.o src/gc/finalize.o src/io/io.o src/io/eventloop.o src/io/syncfile.o src/io/syncstream.o src/io/syncpipe.o src/io/syncsocket.o src/io/fileops.o src/io/dirops.o src/io/procops.o src/io/timers.o src/io/filewatchers.o src/io/signals.o src/io/asyncsocket.o src/6model/reprs.o src/6model/reprconv.o src/6model/containers.o src/6model/parametric.o src/6model/reprs/MVMString.o src/6model/reprs/MVMArray.o src/6model/reprs/MVMHash.o src/6model/reprs/MVMCFunction.o src/6model/reprs/KnowHOWREPR.o src/6model/reprs/KnowHOWAttributeREPR.o src/6model/reprs/P6str.o src/6model/reprs/P6opaque.o src/6model/reprs/MVMCode.o src/6model/reprs/MVMOSHandle.o src/6model/reprs/MVMCompUnit.o src/6model/reprs/MVMStaticFrame.o src/6model/reprs/P6int.o src/6model/reprs/P6num.o src/6model/reprs/Uninstantiable.o src/6model/reprs/HashAttrStore.o src/6model/reprs/MVMThread.o src/6model/reprs/MVMIter.o src/6model/reprs/MVMContext.o src/6model/reprs/SCRef.o src/6model/reprs/Lexotic.o src/6model/reprs/MVMCallCapture.o src/6model/reprs/P6bigint.o src/6model/reprs/NFA.o src/6model/reprs/MVMException.o src/6model/reprs/MVMDLLSym.o src/6model/reprs/MVMMultiCache.o src/6model/reprs/MVMContinuation.o src/6model/reprs/NativeCall.o src/6model/reprs/CPointer.o src/6model/reprs/CStr.o src/6model/reprs/CArray.o src/6model/reprs/CStruct.o src/6model/reprs/ReentrantMutex.o src/6model/reprs/ConditionVariable.o src/6model/reprs/Semaphore.o src/6model/reprs/ConcBlockingQueue.o src/6model/reprs/MVMAsyncTask.o src/6model/reprs/MVMNull.o src/6model/reprs/NativeRef.o src/6model/6model.o src/6model/bootstrap.o src/6model/sc.o src/6model/serialization.o src/mast/compiler.o src/mast/driver.o src/spesh/dump.o src/spesh/graph.o src/spesh/codegen.o src/spesh/candidate.o src/spesh/manipulate.o src/spesh/args.o src/spesh/facts.o src/spesh/optimize.o src/spesh/deopt.o src/spesh/log.o src/spesh/threshold.o src/spesh/inline.o src/spesh/osr.o src/jit/graph.o src/jit/compile.o src/jit/log.o src/strings/decode_stream.o src/strings/ascii.o src/strings/utf8.o src/strings/ops.o src/strings/unicode.o src/strings/latin1.o src/strings/utf16.o src/strings/windows1252.o src/math/bigintops.o src/profiler/instrument.o src/profiler/log.o src/profiler/profile.o src/moar.o src/platform/posix/mmap.o src/platform/posix/time.o src/platform/posix/sys.o src/jit/emit_posix_x64.o 3rdparty/tinymt/libtinymt.a 3rdparty/libuv/libuv.a 3rdparty/dyncall/dyncall/libdyncall_s.a 3rdparty/sha1/libsha1.a 3rdparty/dyncall/dynload/libdynload_s.a 3rdparty/linenoise/liblinenoise.a 3rdparty/libtommath/libtommath.a 3rdparty/dyncall/dyncallback/libdyncallback_s.a -ltommath -latomic_ops -lm -lpthread -lrt -ldl
/usr/bin/ld.bfd.real: 3rdparty/dyncall/dyncall/libdyncall_s.a(dyncall_callvm.o): relocation R_X86_64_PC32 against symbol `gVT_x64' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld.bfd.real: final link failed: Bad value
collect2: error: ld returned 1 exit status
Makefile:484: recipe for target 'libmoar.so' failed
make[2]: *** [libmoar.so] Error 1
make[2]: Leaving directory '/build/moarvm-QgLiKc/moarvm-2015.02'
dh_auto_build: make -j1 NOISY=1 returned exit code 2
debian/rules:37: recipe for target 'override_dh_auto_build' failed
make[1]: *** [override_dh_auto_build] Error 2
make[1]: Leaving directory '/build/moarvm-QgLiKc/moarvm-2015.02'
debian/rules:26: recipe for target 'binary' failed
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
#+end_src

Regards.

Footnotes:
[1] https://github.com/MoarVM/MoarVM/commit/09393586b6207b5aafd0067fc6f6ee339b7d3ff4

[2] https://github.com/MoarVM/MoarVM/issues/187
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
gregor herrmann
2015-03-16 23:08:47 UTC
Permalink
Post by Daniel Dehennin
Post by gregor herrmann
I looked into this now, see the attached patch series.
(Not perfect but a starting point.)
5 days ago it was half fixed upstream[1], today it's fully fixed[2].
Yay!
Post by Daniel Dehennin
[1] https://github.com/MoarVM/MoarVM/commit/09393586b6207b5aafd0067fc6f6ee339b7d3ff4
[2] https://github.com/MoarVM/MoarVM/issues/187
<guess type=wild>
- hardening=+all ?
- or because of @ldflags instead of @cflags?
</guess>

I should have time to take a look tomorrow, unless you beat me to it
:)


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Wir sind Helden: Lass uns verschwinden
Daniel Dehennin
2015-03-16 23:23:51 UTC
Permalink
Yes[1]
Post by gregor herrmann
<guess type=wild>
- hardening=+all ?
</guess>
I should have time to take a look tomorrow, unless you beat me to it
I merged[2] their patches with my pull request, and I explicitely disabled
PIE after adding “+all”[3].

Now it builds cleanly in a schroot, I even install the package and “moar
--help” works \o/.

Regards.

Footnotes:
[1] https://github.com/MoarVM/MoarVM/pull/188

[2] https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-rakudo/pkg-moarvm.git;a=commit;h=807610863ff64609a7b1e1b12c84c25b4ff1b1d1

[3] https://alioth.debian.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=pkg-rakudo/pkg-moarvm.git;a=commit;h=571d44c7622b5dbae314dcd4c3e6d9b65b2fc050
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Dominique Dumont
2015-03-17 07:04:14 UTC
Permalink
Now it builds cleanly in a schroot, I even install the package and “moar
--help” works \o/.
Excellent work :-D
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
gregor herrmann
2015-03-17 21:57:59 UTC
Permalink
Post by Daniel Dehennin
I merged[2] their patches with my pull request, and I explicitely disabled
PIE after adding “+all”[3].
Now it builds cleanly in a schroot, I even install the package and “moar
--help” works \o/.
Yay, great!

Looks like the ITP bug can be tagged pending :)


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: David Bowie: Suffragette City
Daniel Dehennin
2015-03-18 22:16:44 UTC
Permalink
Post by gregor herrmann
Yay, great!
Looks like the ITP bug can be tagged pending :)
The new 2015.03 is out, this will permit to drop the patch ;-)

Regards.
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Daniel Dehennin
2015-03-19 17:16:55 UTC
Permalink
Post by Daniel Dehennin
Post by gregor herrmann
Yay, great!
Looks like the ITP bug can be tagged pending :)
The new 2015.03 is out, this will permit to drop the patch ;-)
Should I change the version of the single entry in debian/changelog or
should I add a new section for this new release.

I wonder since there is no .deb package yet.

Regards.
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
gregor herrmann
2015-03-19 21:40:48 UTC
Permalink
Post by Daniel Dehennin
Post by Daniel Dehennin
The new 2015.03 is out, this will permit to drop the patch ;-)
Should I change the version of the single entry in debian/changelog or
should I add a new section for this new release.
The former because of ...
Post by Daniel Dehennin
I wonder since there is no .deb package yet.
... exactly this reason :)


Cheers,
gregor
--
.''`. Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
: :' : Debian GNU/Linux user, admin, and developer - https://www.debian.org/
`. `' Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
`- NP: Davy Graham: No Preacher Blues
Dominique Dumont
2015-03-20 19:55:00 UTC
Permalink
Now it builds cleanly in a schroot, I even install the package and “moar
--help” works \o/.
I've begun to review the package. A couple of comments:

* I think /usr/lib/moar/libmoar.so should land in a multiarch path (even
though libtommath.so is not currently multiarch...)
* copyright is missing Upstream-contact
* Expat license is duplicated in debian/copyright (which would have been
avoided if you were using cme ...)

All the best
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
Daniel Dehennin
2015-03-20 23:10:46 UTC
Permalink
Post by Dominique Dumont
Post by Daniel Dehennin
Now it builds cleanly in a schroot, I even install the package and “moar
--help” works \o/.
* I think /usr/lib/moar/libmoar.so should land in a multiarch path (even
though libtommath.so is not currently multiarch...)
The library is not versioned[1], so I thought it should not.
Post by Dominique Dumont
* copyright is missing Upstream-contact
Should I set it to some upstream author or the
http://moarvm.org/contributing.html URL?
Post by Dominique Dumont
* Expat license is duplicated in debian/copyright (which would have
been avoided if you were using cme ...)
I tried “cme fix dpkg-copyright” but it does nothing :-/

I fixed it by hand and add the Vcs-* fields too.

Thanks.

Footnotes:
[1] https://github.com/MoarVM/MoarVM/issues/74
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Dominique Dumont
2015-03-21 10:55:16 UTC
Permalink
Post by Daniel Dehennin
Post by Dominique Dumont
* I think /usr/lib/moar/libmoar.so should land in a multiarch path (even
though libtommath.so is not currently multiarch...)
The library is not versioned[1], so I thought it should not.
Hmm right. I did not see that libmoar.so is in its own /usr/lib/moar/
directory. The comment I made a year ago [1] (and forgot since then :-p )
still stands.

Multi-arch is then not important, yet. Let's worry about this later when we
have a more clear picture of what multiarch means for rakudo and moarvm...
(don't hold your breath)
Post by Daniel Dehennin
Post by Dominique Dumont
* Expat license is duplicated in debian/copyright (which would have
been avoided if you were using cme ...)
I tried “cme fix dpkg-copyright” but it does nothing :-/
this is one of the case where cme relies a little bit too much on semantic:
duplicated info like this is not seen: without any other modif, you have to
force a save so that cme will write back a new file.

Come to think of it, there may be a way to detect this ...

Sorry about the confusion.

All the best

[1] https://github.com/MoarVM/MoarVM/issues/74#issuecomment-45533659
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
Dominique Dumont
2015-03-15 15:31:24 UTC
Permalink
Post by gregor herrmann
Maybe you could push the git repo to alioth (to the rakudo team
maybe?), then it's easier for others to clone/look/help out. What dou
you think? - No idea how pkg-rakudo works but I assume they are
welcoming since I know the some guys there And you're already a
project member.
Agreed. pkg-moarvm repo is more than welcome into rakudo project.

Feel free to migrate pkg-moarvm repo in there.

All the best
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
Dominique Dumont
2015-03-31 17:45:49 UTC
Permalink
Hello Daniel

I've used moarvm package as a test case for 'cme update dpkg-copyright'.

Turns out that some copyright entries from 3rdparty directories were missing.
There were also some minor mistakes in the copyright owners. There's a better
chance of having moarvm go through ftp-masters without missing entries in
copyright file...

I've also added a 'fix.scanned.copyright' file in debian to work around some
limitations (or bugs) of licensecheck command.

Last but not least: your previous work on debian/copyright is not wasted:
some files cannot be scanned and 'cme update' did reuse the data you've created.
The fix.scanned.copyright file [1] is needed for files where licensecheck returns
bogus data.

I've pushed the new debian copyright file [2] to copyright-cme-update branch on
pkg-moarvm repo. Feel free to pick up what you want from this file or simply
merge it on master.

I also found (manually, cme is not that magic ;-p ) that the license you
flagged as "Other" is a MIT variant. This update is pushed on master. [3]

Once the copyright is done, I don't see any other issue to upload moarvm.

All the best

[1] https://anonscm.debian.org/cgit/pkg-rakudo/pkg-moarvm.git/tree/debian/fix.scanned.copyright?h=copyright-cme-update
[2] https://anonscm.debian.org/cgit/pkg-rakudo/pkg-moarvm.git/tree/debian/copyright?h=copyright-cme-update
[3] https://anonscm.debian.org/cgit/pkg-rakudo/pkg-moarvm.git/commit/
--
https://github.com/dod38fr/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
Daniel Dehennin
2015-03-31 19:25:21 UTC
Permalink
Post by Dominique Dumont
Hello Daniel
Hello,
Post by Dominique Dumont
I've used moarvm package as a test case for 'cme update dpkg-copyright'.
Turns out that some copyright entries from 3rdparty directories were missing.
There were also some minor mistakes in the copyright owners. There's a better
chance of having moarvm go through ftp-masters without missing entries in
copyright file...
Great, I was looking for a tool to manage this, it's quite cumbersome to
do it by hand.
Post by Dominique Dumont
I've also added a 'fix.scanned.copyright' file in debian to work around some
limitations (or bugs) of licensecheck command.
some files cannot be scanned and 'cme update' did reuse the data you've created.
The fix.scanned.copyright file [1] is needed for files where licensecheck returns
bogus data.
I've pushed the new debian copyright file [2] to copyright-cme-update branch on
pkg-moarvm repo. Feel free to pick up what you want from this file or simply
merge it on master.
Ok, I merged it.

I remove the “author variant” license paragraphes “BSD-2-clause~author”
and “BSD-3-clause~Google” and manually fix the remaining
“BSD-3-clause~author”.
Post by Dominique Dumont
I also found (manually, cme is not that magic ;-p ) that the license you
flagged as "Other" is a MIT variant. This update is pushed on master. [3]
Once the copyright is done, I don't see any other issue to upload moarvm.
I added the Upstream-Contact pointing to the “contribution” web page
since it groups GitHub and IRC informations.

Everything pushed.

Regards.
--
Daniel Dehennin
Récupérer ma clef GPG: gpg --recv-keys 0xCC1E9E5B7A6FE2DF
Fingerprint: 3E69 014E 5C23 50E8 9ED6 2AAD CC1E 9E5B 7A6F E2DF
Dominique Dumont
2015-04-03 17:58:11 UTC
Permalink
Post by Daniel Dehennin
Everything pushed.
Uploaded. Thanks a bunch for your work :-)
--
https://github.com/dod38fr/config-model/ -o- http://search.cpan.org/~ddumont/
http://ddumont.wordpress.com/ -o- irc: dod at irc.debian.org
--
To UNSUBSCRIBE, email to debian-bugs-dist-***@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact ***@lists.debian.org
Continue reading on narkive:
Loading...