Discussion:
Bug#870214: backupninja: sys handler wrongly reports warning due to wrong devices list
quidame
2017-07-31 00:16:30 UTC
Permalink
Package: backupninja
Version: 1.0.1-2
Severity: normal
Tags: upstream

Hi,

After upgrading to Stretch, backupninja's sys handler reports
warnings saying that "the partition table for /dev/mapper/vg-lv
could not be saved" (one warning per Logical Volume)

Reading in /usr/share/backupninja/sys, it appears that the
devices list is filtered from the 'sfdisk -l' output. Then
devices are processed by 'sfdisk -d'.

But the behavior of 'sfdisk -d' has changed:

- Jessie:
***@host:~# sfdisk -d /dev/mapper/vg0-lv0; echo $?
0

- Stretch:
***@host:~# sfdisk -d /dev/mapper/vg0-lv0; echo $?
sfdisk: /dev/mapper/vg0-lv0: does not contain a recognized partition table
1

It means that what was silently ignored is now clearly a case of
failure. But as 'sfdisk -d' by itsel is a purpose of the sys
plugin, and so can't be changed, the way devices are listed
should probably be changed.

Parsing 'lsblk -o kname,type' instead of 'sfdisk -l' to build
the devices list fixed the problem on our server.

Cheers,
quidame



-- System Information:
Debian Release: 8.9
APT prefers oldstable
APT policy: (990, 'oldstable'), (500, 'oldstable-updates'), (500, 'oldstable-proposed-updates'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 3.16.0-4-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.utf8, LC_CTYPE=fr_FR.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages backupninja depends on:
ii bash 4.3-11+deb8u1
ii bsd-mailx [mailx] 8.1.2-0.20141216cvs-2
ii dialog 1.2-20140911-1
ii gawk 1:4.1.1+dfsg-1
ii heirloom-mailx [mailx] 12.5-4
ii mawk 1.3.3-17

backupninja recommends no packages.

Versions of packages backupninja suggests:
ii bzip2 1.0.6-7+b3
ii debconf-utils 1.5.56+deb8u1
ii duplicity 0.6.24-1
ii genisoimage 9:1.1.11-3
ii hwinfo 21.6-1
ii mdadm 3.3.2-5+deb8u2
pn rdiff-backup <none>
ii rsync 3.1.1-3
ii subversion 1.8.10-6+deb8u4
pn trickle <none>
ii wodim 9:1.1.11-3

-- Configuration Files:
/etc/backupninja.conf changed [not included]

-- no debconf information

Loading...